fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170 )

Change subject: rlcmac: Initial ul_tbf data support
......................................................................


Patch Set 11:

(1 comment)

File src/rlcmac/rlc_window.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/3f24f96d_a8f00a50
PS10, Line 77:
> linter is requiring them.
Indeed. vim does not show a newline at the end of file, Gerrit does.
There should be at least one empty line, otherwise git diff will look 
cumbersome.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31170
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I0a01d79d16bbfc63aa88e6bb0f432f3772645730
Gerrit-Change-Number: 31170
Gerrit-PatchSet: 11
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: msuraev <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: neels <[email protected]>
Gerrit-Comment-Date: Mon, 13 Feb 2023 11:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to