laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31258 )

Change subject: bsc_subscriber_conn_fsm: use subslot 0 in case of E1 full 
subslot
......................................................................

bsc_subscriber_conn_fsm: use subslot 0 in case of E1 full subslot

In classic E1 based GSM networks the audio is usually transfered through
16bkps I.460 subslots while 4 16kbps subslots are multiplexed into one
E1 timeslot. However, there may be setups where still 16kbps subslots
are used, but with 1 instead of 4 channels per timeslot. In those cases
the bit offset is 0, while the rate is still 16kbps.

Change-Id: I0d2bc44acaa8e5a28cccfdf7cfb945bf14a4ed30
Related: OS#5198
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c 
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index a19be0c..9c0fdcf 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -721,9 +721,15 @@
                        /* use dynamic RTPBRIDGE endpoint allocation in MGW */
                        epname = mgcp_client_rtpbridge_wildcard(mgcp_client);
                else {
+                       uint8_t i460_bit_offs;
+                       if (for_lchan->ts->e1_link.e1_ts_ss == E1_SUBSLOT_FULL)
+                               i460_bit_offs = 0;
+                       else
+                               i460_bit_offs = for_lchan->ts->e1_link.e1_ts_ss 
* 2;
+
                        epname = mgcp_client_e1_epname(conn, mgcp_client, 
for_lchan->ts->e1_link.e1_nr,
                                                       
for_lchan->ts->e1_link.e1_ts, 16,
-                                                      
for_lchan->ts->e1_link.e1_ts_ss*2);
+                                                      i460_bit_offs);
                }

                conn->user_plane.mgw_endpoint =



2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31258
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0d2bc44acaa8e5a28cccfdf7cfb945bf14a4ed30
Gerrit-Change-Number: 31258
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged

Reply via email to