Attention is currently required from: dexter.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/31415 )

Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1:
I wonder whether this patch still makes sense. Do we really need to inform 
about this now that osmo-bts supports both?


File include/osmocom/gsm/bts_features.h:

https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/a9afd3dd_b1ca6940
PS1, Line 39:   BTS_FEAT_SPEECH_H_V1_RFC5993, /* Whether the BTS model supports 
HR GSM RTP payload in RFC 5883 format */
in same line you say RFC 5993 and 5883. One is wrong.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043
Gerrit-Change-Number: 31415
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 20 Feb 2023 16:49:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to