Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31455 )

Change subject: library/DIAMETER_Emulation: add API for generating Session-Id 
AVP
......................................................................


Patch Set 1:

(3 comments)

File library/DIAMETER_Emulation.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31455/comment/da10e8cd_95d6fdc1
PS1, Line 90:   var uint32_t g_sess_id_seed_h32;
I suspect that's because uint64_t is not supported in TTCN3?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31455/comment/6b385550_0ce0936d
PS1, Line 393:          [] DIAMETER_PROC.getcall(DIAMETEREM_gen_sess_id:{?,?}) 
-> param(identity) {
ah so they are encoded visibly as 2 parts, weird.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31455/comment/4697c5d3_fd44a5fe
PS1, Line 397:                          { g_sess_id_seed_h32 := 
g_sess_id_seed_h32 + 1; }
totally strange formatting here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31455
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0fbd271ad123e9663aab5163915e1edbf5915bb6
Gerrit-Change-Number: 31455
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 22 Feb 2023 13:38:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to