Attention is currently required from: msuraev, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31454 )
Change subject: trau_pcu_ericsson: add testvectors for MCS1-MCS8 ...................................................................... Patch Set 2: (1 comment) File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31454/comment/1127ba21_02a4373a PS2, Line 2087: printf(" ccu_data_ind.tav=%02x\n", frame.u.ccu_data_ind.tav); > I just thought that this wouldn't matter since its just a unit test, but if > you think that it is nec […] The usual approach would be grouping all test vectors into an array, and simply iterating over it in a loop, like many unit tests do. The current code looks more like a result of `-funroll-loops` :P -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7e7e35930a373c9db74faef24f6c404eb5516278 Gerrit-Change-Number: 31454 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: msuraev <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Fri, 24 Feb 2023 22:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
