Attention is currently required from: pespin, fixeria, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 16: (2 comments) File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/5734f1c4_a9443a55 PS16, Line 284: bool use_dt_confirm; what does "dt" mean? File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/1578dbb2_536aaee9 PS5, Line 320: data[sizeof(tlli) + (PAGING_GROUP_LEN - 1 - i)] > I think its still ok to keep it like it is. If we add items like this to > pcuif_proto. […] i also dislike the pattern of unreadable encoding magic, especially in the middle of flow control and other decisions happening; that invites code dup and copy paste errors. Maybe adding packed structs for the other functions would not be a bad idea. (I'm not familiar with this code; if all of this is written in this way then I'd be fine to be outvoted, letting it be known that it objectively is ugly but we choose to live with it...) If it should be unreadable encoding magic, then can we have a separate function doing the encoding? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 16 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Mon, 27 Feb 2023 01:03:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
