Attention is currently required from: arehbein.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/31533 )

Change subject: common: Have PCU socket connection use osmo_wqueue
......................................................................


Patch Set 3:

(1 comment)

File include/osmo-bts/pcuif_proto.h:

https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/80644552_54bd56c5
PS2, Line 8: #define PCU_SOCK_QLENGTH_MAX_DEFAULT       10
> I would say this is rather consistent with https://gerrit.osmocom. […]
Yes because that path is used by both ends to connect. It would be like 
defining a default TCP port here.
But this queue length is something really not related to what both ends use to 
communicate, so it doesn't belong here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1
Gerrit-Change-Number: 31533
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Comment-Date: Tue, 28 Feb 2023 13:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to