Attention is currently required from: neels.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31612 )

Change subject: cosmetic: clarify test_codec_support_bts()
......................................................................


Patch Set 1:

(1 comment)

File src/osmo-bsc/codec_pref.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31612/comment/65ea0819_93407a5e
PS1, Line 197: switch (pchan) {
Not sure if using `switch` here is a big improvement.
I find the current variant shorter and easier to read.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31612
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I13d9b158d08f4938c5aa47ef3134819a4b1f7d29
Gerrit-Change-Number: 31612
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Wed, 01 Mar 2023 08:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to