Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31547 )
Change subject: bssmap_handle_ass_req_ct_data: implement ...................................................................... Patch Set 2: (3 comments) File src/osmo-bsc/codec_pref.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/918a15ee_6af94be3 PS2, Line 117: gsm0804 > gsm0408, not gsm0804. 04.x is radio/Um interface, while 08.x is RAN > interfaces like Abis or A. Done https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/04eeac17_fa82a25b PS2, Line 137: sm0804 > likewise here, gsm0408. or gsm48 if you want to stay like the enum/constant > values. Done File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/28a388cb_ffc4bf9d PS2, Line 677: select_codecs_data > FYI, it's not really a 'codec' in the data case, but a "rate". […] agreed, renamed the functions and moved them to data_rate_pref.c -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I350bea15fd2158eb6edc9bc92f2dca48930736e9 Gerrit-Change-Number: 31547 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 01 Mar 2023 14:29:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
