Attention is currently required from: fixeria, pespin.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31615 )

Change subject: vty: add 'osmodyn' as alias for 'tch/f_tch/h_sdcch8_pdch'
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File src/osmo-bsc/gsm_data.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31615/comment/9a0f49f5_6cec40b9
PS1, Line 192:  { GSM_PCHAN_OSMO_DYN, "OSMODYN" },
> not in the 'ts' / 'phys_chan_config' command we don't! see 
> bts_trx_vty_init(). […]
(and of course i forgot to add a matching gsm_pchant_descs[] entry because the 
stupid gsm_pchan_ids[] is in between, hence the python tests fail, which a vty 
test would have made my realize.)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31615
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I37719edd867c777d1ce944b8e2f1efffac38f00e
Gerrit-Change-Number: 31615
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 01 Mar 2023 22:48:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to