neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31605 )
Change subject: vty: improve doc for 'codec-list'
......................................................................
vty: improve doc for 'codec-list'
Change-Id: I33e6568997bcb1a9466e1e0c1b00718b703e2904
---
M src/osmo-bsc/bsc_vty.c
M tests/msc.vty
2 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index fd08ff5..0472a93 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -2706,8 +2706,9 @@
cfg_net_bsc_codec_list_cmd,
BSC_VTY_ATTR_NEW_LCHAN,
"codec-list .LIST",
- "Set the allowed audio codecs\n"
- "List of audio codecs, e.g. fr3 fr1 hr3\n")
+ "Set the allowed audio codecs and their order of preference\n"
+ "List of audio codecs in order of preference, e.g. 'codec-list
fr3 fr2 fr1 hr3 hr1'."
+ " (fr3: AMR-FR, hr3: AMR-HR, fr2: GSM-EFR, fr1: GSM-FR, hr1:
GSM-HR)\n")
{
struct bsc_msc_data *data = bsc_msc_data(vty);
int i;
diff --git a/tests/msc.vty b/tests/msc.vty
index 555ea34..6edc846 100644
--- a/tests/msc.vty
+++ b/tests/msc.vty
@@ -4,9 +4,9 @@
OsmoBSC(config)# msc 0
OsmoBSC(config-msc)# codec-list?
- codec-list Set the allowed audio codecs
+ codec-list Set the allowed audio codecs and their order of preference
OsmoBSC(config-msc)# codec-list ?
- LIST List of audio codecs, e.g. fr3 fr1 hr3
+ LIST List of audio codecs in order of preference, e.g. 'codec-list fr3 fr2
fr1 hr3 hr1'. (fr3: AMR-FR, hr3: AMR-HR, fr2: GSM-EFR, fr1: GSM-FR, hr1: GSM-HR)
OsmoBSC(config-msc)# # Default list -- should match the default in
osmo_msc_data_alloc()
OsmoBSC(config-msc)# show running-config
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31605
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I33e6568997bcb1a9466e1e0c1b00718b703e2904
Gerrit-Change-Number: 31605
Gerrit-PatchSet: 3
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
