Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31304 )
Change subject: Includes: Remove enum defs, instead include them ...................................................................... Patch Set 4: (1 comment) File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31304/comment/61ce5f3b_e8d5d003 PS1, Line 654: enum gprs_cs { > This enum pretty much already exists in > `libosmocore/include/osmocom/gsm/protocol/gsm_44_060.h`. […] IIUC the one under gsm_44_06.h is used to describe internal data structures / fields, while the other describes bits in a bitmask used in a field sent over a specific protocol (ipaccess Abis OML/RSL). So the purpose is different and hence the values of each one may be different. Can you check the use of those and see if I'm correct? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2883aee12b501a717d5acecd5638882724336e72 Gerrit-Change-Number: 31304 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: arehbein <[email protected]> Gerrit-Comment-Date: Fri, 03 Mar 2023 13:44:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
