msuraev has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31531 )
Change subject: osmo-bts-trx: use bool for true/false flags
......................................................................
osmo-bts-trx: use bool for true/false flags
Change-Id: Iaa97dc36e92797db5f348e0bb79d2191ca0a58b5
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 14 insertions(+), 5 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index 3446018..59603ab 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -1243,7 +1243,7 @@
}
/*! compute UDP port number used for TRX protocol */
-static uint16_t compute_port(struct phy_instance *pinst, int remote, int
is_data)
+static uint16_t compute_port(struct phy_instance *pinst, bool remote, bool
is_data)
{
struct phy_link *plink = pinst->phy_link;
uint16_t inc = 1;
@@ -1269,16 +1269,16 @@
/* open sockets */
rc = trx_udp_open(l1h, &l1h->trx_ofd_ctrl,
plink->u.osmotrx.local_ip,
- compute_port(pinst, 0, 0),
+ compute_port(pinst, false, false),
plink->u.osmotrx.remote_ip,
- compute_port(pinst, 1, 0), trx_ctrl_read_cb);
+ compute_port(pinst, true, false), trx_ctrl_read_cb);
if (rc < 0)
return rc;
rc = trx_udp_open(l1h, &l1h->trx_ofd_data,
plink->u.osmotrx.local_ip,
- compute_port(pinst, 0, 1),
+ compute_port(pinst, false, true),
plink->u.osmotrx.remote_ip,
- compute_port(pinst, 1, 1), trx_data_read_cb);
+ compute_port(pinst, true, true), trx_data_read_cb);
if (rc < 0)
return rc;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31531
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iaa97dc36e92797db5f348e0bb79d2191ca0a58b5
Gerrit-Change-Number: 31531
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: msuraev <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
