Attention is currently required from: fixeria.

msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/31513 )

Change subject: GSMTAP: allow configuring src IP for log messages
......................................................................


Patch Set 4:

(2 comments)

This change is ready for review.

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/4d8ea671_8463b32a
PS2, Line 7: configuring src IP for log messages
> No, it isn't: we can easily have several different components (BTS, mobile 
> etc) with the exact same  […]
Done


File src/vty/logging_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/edeeb2ca_b18ffec2
PS2, Line 180: logging source
> I am sorry, but to me it looks like a wrong direction. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25
Gerrit-Change-Number: 31513
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Sat, 04 Mar 2023 19:29:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: msuraev <[email protected]>
Gerrit-MessageType: comment

Reply via email to