Harald Welte has submitted this change and it was merged.
Change subject: Fix malformed Resource Indication packet
......................................................................
Fix malformed Resource Indication packet
Wireshark was showing a Malformed packet alert, and further
ivnestigation showed that "Resource Information" TLV was missing in the
packet. See GSM 08.58 sections 8.6.1 and 9.3.21 for more information.
Indicating interference level is not yet implemented, but at least now
we avoid sending a malformed packet.
Patch has been validated against a running setup with wireshark in my local PC.
Related: OS#2735
Change-Id: Ie97170811aaf8a089febfa20380ab48ea174056a
---
M src/common/rsl.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Max: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/common/rsl.c b/src/common/rsl.c
index 60f964e..88e240a 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -252,6 +252,7 @@
if (!nmsg)
return -ENOMEM;
// FIXME: add interference levels of TRX
+ msgb_tlv_put(nmsg, RSL_IE_RESOURCE_INFO, 0, NULL);
rsl_trx_push_hdr(nmsg, RSL_MT_RF_RES_IND);
nmsg->trx = trx;
--
To view, visit https://gerrit.osmocom.org/5273
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie97170811aaf8a089febfa20380ab48ea174056a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <[email protected]>
