Attention is currently required from: laforge, pespin, fixeria, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 )
Change subject: Add osmo_sockaddr_to_str_buf3() ...................................................................... Patch Set 11: Code-Review-2 (2 comments) Patchset: PS11: > I'm still not following why do we need this function. […] also possible to pass in an osmo_sockaddr with the port set to zero beforehand File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/71e90348_4b29ad79 PS11, Line 1957: OSMO_STRBUF_PRINTF(sb, "["); I strongly disagree with Pau's earlier review here! We cannot change the previous behavior of osmo_sockaddr_to_str_buf2() -- after this patch, version 2 must continue to print the square braces, also when omitting a port number. This has implications for regression tests' output testing, merging this patch likely fires up red builds all over the place. If the new function should omit braces, then version 3 must be a separate implementation, while version 2 remains unchanged. Very important, this. (My personal opinion is that always printing square braces is a good idea anyway, but that doesn't really matter much for this point) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf Gerrit-Change-Number: 28995 Gerrit-PatchSet: 11 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Mon, 06 Mar 2023 01:44:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
