Attention is currently required from: fixeria.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/31670 )

Change subject: osmo-bts-trx: clean up bts_model_l1sap_down()
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Patchset:

PS1:
weird build error, is the master build broken?


File src/osmo-bts-trx/l1_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/31670/comment/75a65bea_bceb6d63
PS1, Line 403:          lchan = get_lchan_by_chan_nr(trx, chan_nr);
(noting to other reviewers that the next patch adds lchan validity testing 
here, so after that it's not just two lines that could be added to each switch 
case)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I915c8a541249249e3c0b1f2eda4535e7c52db79f
Gerrit-Change-Number: 31670
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 06 Mar 2023 02:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to