Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31669 )
Change subject: gsm0502: add burst length definitions from chapter 5.2 ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/gsm0502.h: https://gerrit.osmocom.org/c/libosmocore/+/31669/comment/7f25f63d_c69702bc PS1, Line 36: #define GSM_NBITS_NB_GMSK_PAYLOAD 2 * 58 > I think shitfting operations take precedence over multiplication? No, see https://en.cppreference.com/w/c/language/operator_precedence. Shifting operations have even lower prio than sum and division, this is why we usually put braces around them. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c38ccc2b64ba9046bb3b1221d99cc55ec493802 Gerrit-Change-Number: 31669 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 06 Mar 2023 09:14:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
