Attention is currently required from: laforge, dexter.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31687 )

Change subject: pcu_sock: only allow Ericsson RBS to connect to external PCU
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31687/comment/6dc41cd7_c6193fdd 
PS2, Line 964: return -EINVAL;
So when this condition is true, osmo-bsc would fail to start printing:

  %% Error creating PCU socket `%s' for BTS %u

But nothing specific *why* it failed. Please print something here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31687
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I18d190d661b06015419078382915c4606be01b04
Gerrit-Change-Number: 31687
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 07 Mar 2023 12:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to