laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31679 )
Change subject: pcu_sock: do not mess with the osmo fd flags directly
......................................................................
pcu_sock: do not mess with the osmo fd flags directly
When we disable the old socket connection, let's use
osmo_fd_read_disable().
Change-Id: I6b6854e9881c79b5c4794bde4ba4f6841dd06386
---
M src/common/pcu_sock.c
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 119d7b8..7e87f6d 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -1172,7 +1172,7 @@
if (conn_bfd->fd >= 0) {
LOGP(DPCU, LOGL_NOTICE, "PCU connects but we already have
another active connection ?!?\n");
/* We already have one PCU connected, this is all we support */
- state->listen_bfd.when &= ~OSMO_FD_READ;
+ osmo_fd_read_disable(&state->listen_bfd);
close(fd);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31679
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6b6854e9881c79b5c4794bde4ba4f6841dd06386
Gerrit-Change-Number: 31679
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: msuraev <[email protected]>
Gerrit-MessageType: merged
