Patch Set 5: (1 comment)
https://gerrit.osmocom.org/#/c/5158/5/src/tbf.cpp File src/tbf.cpp: Line 478: tbf->stop_timers("freeing TBF"); > This is pretty confusing. Can we rename this one to "stop_all_timers" ? Fur That's fixed in follow-up patches which remove stop_timer() entirely. -- To view, visit https://gerrit.osmocom.org/5158 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0305873ca47534f53441247217881da59625e1f7 Gerrit-PatchSet: 5 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
