Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31695 )
Change subject: in ran_msg, return gsm0808_speech_codec (intra-MSC) ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/31695/comment/e19901b4_517a305f PS3, Line 15: - CN side: introduce flag ran_msg.assignment_complete.codec_with_iuup, > I think this field was incorrectly added in previous commit? nope, that was ran_infra.force_mgw_codecs_to_ran. So, basically - I chose to force RAN MGW conn to do IUFP always (ran_infra.force_mgw_codecs_to_ran), and - in ran_msg to only tell the gsm0808 codec it is *compatible* with. - Then I had the problem that for the time being, i still want to force IuUP towards CN for now (better change from IuUP <-> IuUP to IuUP <-> AMR/RTP in a separate patch), and I want to get rid of the "if UTRAN" special cases. So this flag is actually only needed for the intermediate phase where we still forward IuUP to the CN. As soon as we always decaps to plain RTP on the CN side, we only need the ran_infra forced codecs, because we never use IUFP on the CN anymore. Still i think this flag clarifies a bit what is actually going on, even if we will soon stop actually using it. - The ran_infra.force_mgw_codecs_to_ran is important because the first CRCX happens before assignment starts, that already needs to be IuUP aware for the IuUP Initialization to work (which happens before RAB Assignment completes). - The ran_msg.codec tells the msc_a code that after assignment is done, the assignment is compatible with a given gsm0808_speech_codec (namely AMR), and please use AMR on the CN side. - Then this flag ran_msg.codec_with_iuup says "look, you should use the ran_msg.codec (AMR) plain as it is towards CN, but btw it is coming in on IuUP, so if you still want to forward IuUP to the CN like in olden times then go ahead" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia666cb697fbd140d7239089628faed93860ce671 Gerrit-Change-Number: 31695 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:16:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
