Attention is currently required from: msuraev.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/31661 )

Change subject: mobile: allow configuring local GSMTAP address
......................................................................


Patch Set 5:

(1 comment)

File src/host/layer23/src/common/vty.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/31661/comment/40f47863_8fb7e509
PS5, Line 199: Local IP address
Now you have incomplete documentation for `VTY_IPV46_CMD`, which requires two 
docstrings. Are you testing it before merging at all? Please submit a fixup.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31661
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia1555db653cf0bb20af74617f33aad31c971bfdb
Gerrit-Change-Number: 31661
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: msuraev <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: msuraev <[email protected]>
Gerrit-Comment-Date: Wed, 08 Mar 2023 18:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to