Attention is currently required from: jolly, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30762 )
Change subject: isdn: Add V.110 encoder/decoder ...................................................................... Patch Set 11: (3 comments) File src/isdn/v110.c: https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/150c264a_3f57c19e PS10, Line 14: /* (C) 2022 by Harald Welte <lafo...@osmocom.org> > Missing license header. Done https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/49e81271_0376690e PS10, Line 30: \param[out] caller-allocated > `\param[out] fr ... […] Done https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/069bbaeb_21530aa1 PS10, Line 31: * \param[in] ra_bits One V.110 frame as 80 unpacked bits. */ > Missing `\param` for `n_bits`, also missing `\returns`. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b5fd3847d3bfb0a0f763e0574893962ec699680 Gerrit-Change-Number: 30762 Gerrit-PatchSet: 11 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: jolly <andr...@eversberg.eu> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 08 Mar 2023 23:14:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
