Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 )
Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv ...................................................................... Patch Set 1: (1 comment) File src/libosmo-pfcp/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/2d5cf2d4_f0584f21 PS1, Line 68: gen__pfcp_ies_auto_LDFLAGS > Regarding order: lower level libs (eg libosmcoore) should be *after* the libs > depending on it. […] this is the same fix: LDADD I presume appends libs to the AM_LDFLAGS from above. Since AM_LDFLAGS include LIBOSMOCORE_LIBS, then the local lib is appended by LDADD after libosmocore, which then fails. By using LDFLAGS, not LDADD, the order is being fixed, because no other libs are listed before libosmo-gtlv.a. Now from a different angle, linking is only done for built programs. Since this Makefile.am builds only a library (not linked) and the gen__pfcp... program (linked), that means the global AM_LDFLAGS only applies to this gen__pfcp program anyway, so it makes no sense to set AM_LDFLAGS and then also have a separate LDFLAGS for the gen__pfcp program. I can just use either the global AM_LDFLAGS or a gen_pfcp_..._LDFLAGS. Hope this is correct now... certainly works on my box. re: "COVERAGE_LDFLAGS should be in gen__pfcp_ies_auto_LDFLAGS . Why are they mixed up?" But so far I don't understand why you would say that COVERAGE has to be in LDFLAGS, when both LDFLAGS and LDADD just end up adding cmdline args to the linker. should COVERAGE come first?? I presume LDFLAGS and LDADD are the same thing, one replaces the earlier LDFLAGS and the other doesn't replace but just append? I have no idea about COVERAGE_LDFLAGS, if that needs fixing let's do it in a separate patch. I don't even know what COVERAGE is supposed to do... just took it from another build tree. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66 Gerrit-Change-Number: 31741 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 09 Mar 2023 00:01:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
