Attention is currently required from: laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/31756 )

Change subject: rlcmac: Log sched of PktCtrlAck requested by UL ASS poll
......................................................................


Patch Set 2:

(1 comment)

File src/rlcmac/sched.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/31756/comment/e4f4181a_5178ead6
PS2, Line 207: (ts=%u,fn=%u,usf=%u)
> this function alone seems to be using the same format string for printing at 
> least four times now. […]
I expect this code to evolve a bit as I'm adding new features and we are fixing 
lower level scheduler stuff, so I wouldn't spend more time on that until later. 
Actually USF may not be really relevant there.
Let's look at this later when the whole RTS.ind/DATA.ind is clear and set.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31756
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I81ac177d7abdcd49d2b231ae059ec859b433dd03
Gerrit-Change-Number: 31756
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 09 Mar 2023 09:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to