Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/31785 )
Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Pau I saw your opinion, thanks, no need to post it again on each and every
> patch.
I'm giving my opinion in order to find out what's the rationale behind this
patch, whether it is really improving anyhow the situation.
Also, I'm giving my opinion because I need to invest time to review all these
patches. Given you are not interested to hear it or save my/your time, better
find someone else who review them.
That's the automake rule to generate the rules:
%.o:%.c
$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0
Gerrit-Change-Number: 31785
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 09 Mar 2023 11:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment
