Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31808 )
Change subject: select: Optimize osmo_fd_get_by_fd ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > we can OSMO_ASSERT if we back-port a fix to osmo-mgw and release patch > releases for at least the la […] ACK I'll submit a backport for osmo-mgw patch. File src/core/select.c: https://gerrit.osmocom.org/c/libosmocore/+/31808/comment/a3c7fbbd_26ba80ef PS2, Line 78: 1024B > 1024B as in bytes? Every pointer surely is 4/8 bytes large, so number of > entries != bytes yes, 1024 bytes = 128 fds in 64bit systems. The idea is to allocate mem blocks which are power of 2. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8b71547df8bed84192cb160479fa3debf9b7eade Gerrit-Change-Number: 31808 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 09 Mar 2023 21:11:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
