Attention is currently required from: pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31801 )

Change subject: bts: add function to check if a BTS has a BSC co located PCU
......................................................................


Patch Set 2:

(1 comment)

File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/31801/comment/8f3e574a_2412385f
PS1, Line 754: static inline int bsc_co_located_pcu(const struct gsm_bts *bts)
> bool
Hmm. All other check functions are int too. Then we should migrate all of them 
to bool to maintain consistency.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31801
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I23ed4219e5ebd188867c17f387ca877efa9bc3b0
Gerrit-Change-Number: 31801
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 10 Mar 2023 09:14:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to