Attention is currently required from: laforge, fixeria, dexter.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/31417 )

Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/ae75cc18_700d34b4
PS5, Line 1260:                 if (OSMO_UNLIKELY((resp_msg->len != 
GSM_HR_BYTES + 1)
this alignment looks weird, given that the next line sees to be inside the 
OSMO_UNLIKELY macro.


https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/3d06c679_226aedc0
PS5, Line 1267:                             && 
bts_internal_flag_get(lchan->ts->trx->bts, 
BTS_INTERNAL_FLAG_SPEECH_H_V1_RTP_TS101318))) {
same



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31417
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e
Gerrit-Change-Number: 31417
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Fri, 10 Mar 2023 13:32:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to