Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31762 )
Change subject: libosmo-gtlv/Makefile.am: drop unused AM_LDFLAGS ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/libosmo-gtlv/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31762/comment/4968b305_2fc2b87e PS1, Line 14: LIBOSMOCORE_LIBS I think you still want `libosmo-gtlv.la` to depend on libosmocore, right? If so, you should move `$(LIBOSMOCORE_LIBS)` to `libosmo_gtlv_la_LIBADD` (not `LDFLAGS`!). -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I6fd777bed9366c35f5b1453cde1e6f5c1617e338 Gerrit-Change-Number: 31762 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Fri, 10 Mar 2023 22:45:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
