Attention is currently required from: osmith, neels, pespin, fixeria.

msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/31513 )

Change subject: GSMTAP: allow configuring src IP for log messages
......................................................................


Patch Set 13:

(1 comment)

File src/core/logging_gsmtap.c:

https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/470a04a8_a3974037
PS12, Line 186:                 target->tgt_gsmtap.src_addr = 
talloc_strdup(target, src);
> Fine if you checked manually then. […]
Ah, got it now - logging_vty_test is generic test fixture made by Neels. What 
it does is defined in logging_vty_test.vty file which is modified as part of 
this commit. To see the whole thing in action you have to enable external tests 
at ./configure stage.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25
Gerrit-Change-Number: 31513
Gerrit-PatchSet: 13
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: neels <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 13 Mar 2023 20:16:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: msuraev <[email protected]>
Gerrit-MessageType: comment

Reply via email to