Attention is currently required from: neels.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 )

Change subject: libosmo-pfcp.pc: move libosmogsm to Requires
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> so libosmo-pfcp.so is not linked against libosmogsm.so: […]
And indeed, the linker command while building libosmo-pfcp seems to be:

libtool: link:  gcc -shared  -fPIC -DPIC  .libs/pfcp_endpoint.o 
.libs/pfcp_ies_custom.o .libs/pfcp_msg.o .libs/pfcp_strs.o .libs/pfcp_cp_peer.o 
.libs/pfcp_ies_auto.o    -fsanitize=address -fsanitize=undefined   -pthread 
-Wl,-soname -Wl,libosmo-pfcp.so.0 -Wl,-version-script 
-Wl,.libs/libosmo-pfcp.ver -o .libs/libosmo-pfcp.so.0.1.0

- no -losmogsm in that linker command!



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8
Gerrit-Change-Number: 31760
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Tue, 14 Mar 2023 20:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to