Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31969 )
Change subject: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/shared/l1gprs.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31969/comment/99780fc7_7bb861cf PS1, Line 138: "%s(): " LOG_TBF_FMT " not found\n", > No, this is correct. I am passing the format string arguments expected by > `LOG_TBF_FMT` manually. Yes but my point is that passing that LOG_TBF_FMT here makes the code more difficult to understand because you are not sure what you pass matches with what you have in the macro until you look at it. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie3e7b5a8a205d4410de458dec2fde466493d31ce Gerrit-Change-Number: 31969 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 20 Mar 2023 09:17:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
