Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32014 )
Change subject: Fix parsing of TLV_TYPE_SINGLE_TV ...................................................................... Patch Set 1: (2 comments) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/32014/comment/92651c09_4a8210bf PS1, Line 1779: GSM48_IE_CIP_MODE_SET > In osmo-bsc.git I see this IEI used as follows: […] Then we need to fix those projects and make them depend on libosmocore > 1.8.0, because with current state anyway encoding/decoding of those IEs is broken. File src/gsm/tlv_parser.c: https://gerrit.osmocom.org/c/libosmocore/+/32014/comment/abfd622d_5af11b5a PS1, Line 244: & 0xf0 > Applying the mask in not needed anymore, given that you shift `uint8_t`? Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I799e35dc8d4d153fa63bf50563a5482cdf4de2d7 Gerrit-Change-Number: 32014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 22 Mar 2023 12:39:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
