Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29081 )
Change subject: binaries/Makefile: s/INCLUDES/AM_CPPFLAGS/ ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > ping? After several attempts and several more commits which I decided to not push, I am giving up on this patch. I am fixing one thing and breaking three other things. It does not make sense to fix the build system in libsmpp34.git, it's a mess and needs to be rewritten from scratch, IMHO. Let me know if you think I should spend several hours reworking everything. I think it makes no sense, so abandoning this patch. -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I9343f53c125be8e4c7590164a8541d9fe114deb5 Gerrit-Change-Number: 29081 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:25:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
