Attention is currently required from: dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/25805 )

Change subject: pySim-shell: add cardinfo command
......................................................................


Patch Set 4:

(1 comment)

File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/25805/comment/9c3e7511_f4c05f0a
PS2, Line 611: p
> Reading the ATR would require a card reset. […]
pyscard.connection.getATR() should just retrieve the cached ATR from the last 
time the card was reset.  I doubt it would issue a new reset? at lesat that's 
how I remember it.

For other card readers, our "driver" classes should implement the same, if they 
don't do that already: Always keep the most recent ATR in cache so that the 
user of the "driver" api can retrieve it later.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/25805
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If31ed17102dc0108e27a5eb0344aabaaf19b19f9
Gerrit-Change-Number: 25805
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 23 Mar 2023 08:31:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment

Reply via email to