fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32023 )

Change subject: gsm_04_08: document/clarify enum gsm48_chan_mode values
......................................................................

gsm_04_08: document/clarify enum gsm48_chan_mode values

The values are defined in 3GPP TS 44.018, section 10.5.2.6.  Only the
radio interface rates for CSD (GSM48_CMODE_DATA_*) are given, but the
respective service rates can be found in 3GPP TS 45.003.

Change-Id: I716027f73ab6f20037f6de16e4a3740811aa38a2
Related: OS#1572
---
M include/osmocom/gsm/protocol/gsm_04_08.h
1 file changed, 31 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved




diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h 
b/include/osmocom/gsm/protocol/gsm_04_08.h
index 7b8979b..7522623 100644
--- a/include/osmocom/gsm/protocol/gsm_04_08.h
+++ b/include/osmocom/gsm/protocol/gsm_04_08.h
@@ -746,18 +746,33 @@
        uint8_t mode;
 } __attribute__ ((packed));

+/*! 10.5.2.6 Channel Mode value */
 enum gsm48_chan_mode {
+       /*! Signalling only (TCH/F or TCH/H)  */
        GSM48_CMODE_SIGN        = 0x00,
+       /*! Speech: FR (TCH/FS) or HR (TCH/HS) */
        GSM48_CMODE_SPEECH_V1   = 0x01,
-       GSM48_CMODE_SPEECH_EFR  = 0x21,
-       GSM48_CMODE_SPEECH_AMR  = 0x41,
+       /*! Speech: EFR (TCH/EFS) */
+       GSM48_CMODE_SPEECH_EFR  = 0x21, /*!< a.k.a. V2 */
+       /*! Speech: AMR (TCH/AFS or TCH/AHS) */
+       GSM48_CMODE_SPEECH_AMR  = 0x41, /*!< a.k.a. V3 */
+
+       /*! CSD: 14.5 kbit/s radio interface rate, 14.4 kbit/s services 
(TCH/F14.4) */
        GSM48_CMODE_DATA_14k5   = 0x0f,
+       /*! CSD: 12.0 kbit/s radio interface rate, 9.6 kbit/s services 
(TCH/F9.6) */
        GSM48_CMODE_DATA_12k0   = 0x03,
+       /*! CSD: 6.0 kbit/s radio interface rate, 4.8 kbit/s services 
(TCH/{F,H}4.8) */
        GSM48_CMODE_DATA_6k0    = 0x0b,
+       /*! CSD: 3.6 kbit/s radio interface rate, 2.4 kbit/s and less services 
(TCH/{F,H}2.4) */
        GSM48_CMODE_DATA_3k6    = 0x13,
+
+       /*! Same as GSM48_CMODE_SPEECH_V1, in VAMOS mode */
        GSM48_CMODE_SPEECH_V1_VAMOS     = 0xc1,
+       /*! Same as GSM48_CMODE_SPEECH_EFR, in VAMOS mode */
        GSM48_CMODE_SPEECH_V2_VAMOS     = 0xc2,
+       /*! Same as GSM48_CMODE_SPEECH_AMR, in VAMOS mode */
        GSM48_CMODE_SPEECH_V3_VAMOS     = 0xc3,
+       /*! Speech: FR AMR-WB, in VAMOS mode */
        GSM48_CMODE_SPEECH_V5_VAMOS     = 0xc5,
 };


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32023
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I716027f73ab6f20037f6de16e4a3740811aa38a2
Gerrit-Change-Number: 32023
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged

Reply via email to