Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 )
Change subject: hnbgw: add f_rua_expect() ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > > An altstep cannot have a return value […] The deeper point is that i don't really want to have an altstep that can be integrated into other altsteps, I want these functions to specifically expect a given message within a limited time, so that i get nicer test failure logging without the need to search far and wide which message may have gone missing. For this, a function is better suited than an altstep. If we ever need altsteps too, then we can find a nifty way to reduce code dup, but so far i only want those parts for which functions are suited well. (altstep inout parameters have nontrivial limitations on the scoping.) (i don't want to have to start a timer externally whenever calling f_rua_expect(), i want a convenient implicit timer) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29e6b7659ba53efee9f676197b502f79780ead7e Gerrit-Change-Number: 31765 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 24 Mar 2023 03:57:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
