Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31978 )
Change subject: BTS_Tests: do L1CTL.clear in f_pcu_to_l1() ...................................................................... Patch Set 1: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31978/comment/c5ec7478_dd303d5c PS1, Line 5574: L1CTL.clear; > Iedally you should discard those messages in the alt statement, with a > repeat; to keep reading. This is exactly what we're currently doing. But sometimes you may want to instrument the "wildcard" `L1CTL.receive { ... }` statement to print all non-matching messages, and you get tons of BCCH messages, what I find a bit annoying. > you may run into race conditions here clearing stuff and then reading. It's unlikely given that it takes the BTS some time to transmit the block over the air (even in the virtual env), but yeah, let's better move this one above. Done in the next patchset. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57b745bcfc48dc621359658cd43d2ee622fde49b Gerrit-Change-Number: 31978 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sat, 25 Mar 2023 14:31:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
