laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/32089 )


Change subject: cosmetic: Replace %i with %d
......................................................................

cosmetic: Replace %i with %d

Our linter will fail on %i, so let's replace any legacy occurrences with %d

Change-Id: Ic302915bd5576d3e1f77668918f005d651daf21a
---
M src/common/vty.c
M src/osmo-bts-octphy/l1_oml.c
M src/osmo-bts-octphy/octphy_hw_api.c
3 files changed, 15 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/32089/1

diff --git a/src/common/vty.c b/src/common/vty.c
index dd1b07f..bd18221 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -418,9 +418,9 @@
        vty_out(vty, " rtp port-range %u %u%s", bts->rtp_port_range_start,
                bts->rtp_port_range_end, VTY_NEWLINE);
        if (bts->rtp_ip_dscp != -1)
-               vty_out(vty, " rtp ip-dscp %i%s", bts->rtp_ip_dscp, 
VTY_NEWLINE);
+               vty_out(vty, " rtp ip-dscp %d%s", bts->rtp_ip_dscp, 
VTY_NEWLINE);
        if (bts->rtp_priority != -1)
-               vty_out(vty, " rtp socket-priority %i%s", bts->rtp_priority, 
VTY_NEWLINE);
+               vty_out(vty, " rtp socket-priority %d%s", bts->rtp_priority, 
VTY_NEWLINE);
        vty_out(vty, " paging queue-size %u%s", 
paging_get_queue_max(bts->paging_state),
                VTY_NEWLINE);
        vty_out(vty, " paging lifetime %u%s", 
paging_get_lifetime(bts->paging_state),
diff --git a/src/osmo-bts-octphy/l1_oml.c b/src/osmo-bts-octphy/l1_oml.c
index 5894c21..5ab6d09 100644
--- a/src/osmo-bts-octphy/l1_oml.c
+++ b/src/osmo-bts-octphy/l1_oml.c
@@ -1173,7 +1173,7 @@
        tOCTVC1_MAIN_MSG_APPLICATION_INFO_RSP *air =
                (tOCTVC1_MAIN_MSG_APPLICATION_INFO_RSP *) resp->l2h;

-       snprintf(ver_hdr, sizeof(ver_hdr), "%02i.%02i.%02i-B%i",
+       snprintf(ver_hdr, sizeof(ver_hdr), "%02d.%02d.%02d-B%d",
                cOCTVC1_MAIN_VERSION_MAJOR, cOCTVC1_MAIN_VERSION_MINOR,
                cOCTVC1_MAIN_VERSION_MAINTENANCE, cOCTVC1_MAIN_VERSION_BUILD);

diff --git a/src/osmo-bts-octphy/octphy_hw_api.c 
b/src/osmo-bts-octphy/octphy_hw_api.c
index 6da038b..271ed04 100644
--- a/src/osmo-bts-octphy/octphy_hw_api.c
+++ b/src/osmo-bts-octphy/octphy_hw_api.c
@@ -119,7 +119,7 @@

        LOGP(DL1C, LOGL_INFO, "RF-PORT-STATS.resp Idx=%u RadioStandard=%s, "
                "Rx(Bytes=%u, Overflow=%u, AvgBps=%u, Period=%uus, Freq=%u) "
-               "Tx(Bytes=%i, Underflow=%u, AvgBps=%u, Period=%uus, Freq=%u)\n",
+               "Tx(Bytes=%d, Underflow=%u, AvgBps=%u, Period=%uus, Freq=%u)\n",
                psr->ulPortIndex,
                get_value_string(radio_std_vals, psr->ulRadioStandard),
                psr->RxStats.ulRxByteCnt, psr->RxStats.ulRxOverflowCnt,

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32089
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic302915bd5576d3e1f77668918f005d651daf21a
Gerrit-Change-Number: 32089
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-MessageType: newchange

Reply via email to