Attention is currently required from: neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32043 )
Change subject: logging: add 'logging timezone (localtime|utc)' ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: Marking with -1 since I'm not the only one thinking set_timezone() should fail if not supported by the system. File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/32043/comment/b9c67540_4a046f59 PS1, Line 874: target->timezone = timezone; > i don't agree. i would not want to duplicate some enum validation code here. > […] How does the caller (the user) know if it is setting a timezone which is not supported by his system? Does he need to go check cryptic support documentation in Narnia? This *is* the place where the user should get to know that it is trying to set a value which is not going to work properly on the current system. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7f868b47bf8f8dfcf85e735f490ae69b18111af4 Gerrit-Change-Number: 32043 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:15:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
