Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32093 )
Change subject: Replace explicit gsm_lchan_name() calls with LOGPLCHAN ...................................................................... Patch Set 2: (4 comments) File src/common/rsl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5518): https://gerrit.osmocom.org/c/osmo-bts/+/32093/comment/3096b769_87c64101 PS2, Line 3298: gsm_pchan_name(ts->pchan), pdch_act? "PDCH" : "TCH/F", ts->flags); spaces required around that '?' (ctx:VxW) File src/osmo-bts-lc15/oml.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5518): https://gerrit.osmocom.org/c/osmo-bts/+/32093/comment/50b391c0_84c50973 PS2, Line 937: LOGPLCHAN(lchan, DL1C, LOGL_INFO, "%s tch_mode=0x%02x\n", __FUNCTION__, lchan->tch_mode); __func__ should be used instead of gcc specific __FUNCTION__ File src/osmo-bts-oc2g/oml.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5518): https://gerrit.osmocom.org/c/osmo-bts/+/32093/comment/38cfaac0_3ca25dd9 PS2, Line 952: LOGPLCHAN(lchan, DL1C, LOGL_INFO, "%s tch_mode=0x%02x\n", __FUNCTION__, lchan->tch_mode); __func__ should be used instead of gcc specific __FUNCTION__ File src/osmo-bts-sysmo/oml.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5518): https://gerrit.osmocom.org/c/osmo-bts/+/32093/comment/fd999cc7_96d926cd PS2, Line 945: __FUNCTION__, lchan->tch_mode); __func__ should be used instead of gcc specific __FUNCTION__ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If4f4f555f5ca61dfa624b298805f5375efc0b137 Gerrit-Change-Number: 32093 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Tue, 28 Mar 2023 13:43:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
