Attention is currently required from: falconia, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/32098 )

Change subject: common: implement rtp continuous-streaming mode
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/8200b54c_9875cef8
PS3, Line 1651:                         if (lchan->abis_ip.osmux.use)
not really critical but since you are already splitting the 
send_ul_rtp_packet() function, you could also split this into 
skip_ul_rtp_packet or similar. It's fine as it now too.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32098
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic0e2edf2ed90ba0ac6bee5e7d9629bf0255e256d
Gerrit-Change-Number: 32098
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Wed, 29 Mar 2023 09:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to