Attention is currently required from: pespin, fixeria, dexter. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31885 )
Change subject: PCU IF: Update NSE timer field ...................................................................... Patch Set 1: (1 comment) File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/26da5482_d4f29348 PS1, Line 156: PCU_IF_NUM_NSE_TIMERS > Extending the timer at the end of the struct would change the message size > and hence would break the […] So, how exactly do I go about updating the PCU IF now/ how does Osmocom go about these version bumps? It's also not clear to me right now what change is preferred... pespin's last comment > I wouldn't really care for now about that, I don't expect the size of this > array to change lots of times. I'd leave it as/where it is, update the size > now like you did. sounded like this patch would be alright (?) and I should just add a version bump for osmo-bts, osmo-bsc and osmo-pcu? Last but not least, since that was also mentioned: Should we add this PCU IF change to the version bump in https://gerrit.osmocom.org/c/osmo-bts/+/31600/1/include/osmo-bts/pcuif_proto.h ? This concerns two other patches of mine as well: https://gerrit.osmocom.org/c/osmo-pcu/+/31886 and https://gerrit.osmocom.org/c/osmo-bsc/+/31880 (which I will probably have to change so as to separate out the PCU_IF change) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb Gerrit-Change-Number: 31885 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Fri, 31 Mar 2023 14:33:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
