Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/32154 )

Change subject: Introduce libosmo-gprs-sm
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

Patchset:

PS3:
LGTM!


File include/osmocom/gprs/sm/sm_private.h:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32154/comment/47f344ef_cf456745
PS3, Line 58: struct_endianness
This script does weird things here, making the code hard to read :/



--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32154
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I9b4a9a6364f7799540475e7e1d10ab2310768281
Gerrit-Change-Number: 32154
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 31 Mar 2023 15:20:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to