Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32185 )
Change subject: xua_rkm: handle_rkey_reg(): properly handle Routing Context IE ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not sure if this will address the problem in general. AFAIR, the entire libosmo-sigtran codebase was written based on the assumption that routing context 0 means "no routing context IE is used". Yes, in theory, an explicit routing context 0 IE is possible to use (as per spec), but I think it is a valid constraint to say we don't support routing context 0. So either the user wants to use the routing context IE on a given link (and then has to use a non-zero routing context), or they do not want to use a routing context at all (which we represent as routing context 0 internally). -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ide7b1d62cc78effdda9950112f495c9ca276cae5 Gerrit-Change-Number: 32185 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Sun, 02 Apr 2023 16:29:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
