Attention is currently required from: falconia, neels, laforge.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/32078 )

Change subject: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

File src/trau/trau_rtp_conv.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/32078/comment/832cb72c_8304c966
PS1, Line 282: } else if (data_len == 0) {
             :          /* C1 .. C5: idle speech */
             :          tf->c_bits[0] = 0;
             :          tf->c_bits[1] = 1;
             :          tf->c_bits[2] = 1;
             :          tf->c_bits[3] = 1;
             :          tf->c_bits[4] = 0;
> > if (UL) { […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32078
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7f21e2210bba9ef87f1af515a001a0cfc1c0a1d8
Gerrit-Change-Number: 32078
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: neels <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Mon, 03 Apr 2023 13:25:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia <[email protected]>
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to