Attention is currently required from: falconia, laforge, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32197 )

Change subject: include/osmocom/gsm/protocol: add gsm_06_31.h
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> As mentioned, I think we want everything to be prefixed OSMO_* nowadays.
Agreeing with Pau.

Also, I am not sure if it's really worth having this enum in a separate file. I 
doubt there is going to be more definitions in this file, given that the 
respective 3GPP document is quite small (only 13 pages in V8.0.1). Not critical 
though.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32197
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If004b668778d3d9cf6cd998b3af2dbfa83691529
Gerrit-Change-Number: 32197
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 03 Apr 2023 21:14:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to