pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/32219 )
Change subject: oml.c: Remove dot character at the end of log lines
......................................................................
oml.c: Remove dot character at the end of log lines
Change-Id: Iaf061bb752f9808a6ab31049b9e87920a6b07f3d
---
M src/common/oml.c
1 file changed, 18 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/19/32219/1
diff --git a/src/common/oml.c b/src/common/oml.c
index 5ffb6ff..5474fb1 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -217,7 +217,7 @@
add_trx_attr(out_msg, trx);
break;
default:
- LOGP(DOML, LOGL_ERROR, "%s: O&M Get Attributes [%u], %s
is unsupported by TRX.\n",
+ LOGP(DOML, LOGL_ERROR, "%s: O&M Get Attributes [%u], %s
is unsupported by TRX\n",
gsm_trx_name(trx), i,
get_value_string(abis_nm_att_names, attr[i]));
/* Push this tag to the list of unsupported attributes
*/
buf = msgb_push(out_msg, 1);
@@ -256,7 +256,7 @@
add_bts_feat(out_msg, bts);
break;
default:
- LOGP(DOML, LOGL_ERROR, "O&M Get Attributes [%u], %s is
unsupported by BTS.\n", i,
+ LOGP(DOML, LOGL_ERROR, "O&M Get Attributes [%u], %s is
unsupported by BTS\n", i,
get_value_string(abis_nm_att_names, attr[i]));
/* Push this tag to the list of unsupported attributes
*/
buf = msgb_push(out_msg, 1);
@@ -450,13 +450,13 @@
/* alter message type */
if (cause) {
- LOGPFOH(DOML, LOGL_NOTICE, foh, "Sending FOM NACK with cause
%s.\n",
+ LOGPFOH(DOML, LOGL_NOTICE, foh, "Sending FOM NACK with cause
%s\n",
abis_nm_nack_cause_name(cause));
foh->msg_type += 2; /* nack */
/* add cause */
msgb_tv_put(msg, NM_ATT_NACK_CAUSES, cause);
} else {
- LOGPFOH(DOML, LOGL_DEBUG, foh, "Sending FOM ACK.\n");
+ LOGPFOH(DOML, LOGL_DEBUG, foh, "Sending FOM ACK\n");
foh->msg_type++; /* ack */
}
@@ -566,7 +566,7 @@
oml_tx_failure_event_rep(&bts->mo, NM_SEVER_MAJOR,
OSMO_EVT_WARN_SW_WARN,
"Given ARFCN %u is not
supported",
arfcn);
- LOGPFOH(DOML, LOGL_ERROR, foh, "Given ARFCN %u is not
supported.\n", arfcn);
+ LOGPFOH(DOML, LOGL_ERROR, foh, "Given ARFCN %u is not
supported\n", arfcn);
return oml_fom_ack_nack(msg, NM_NACK_FREQ_NOTAVAIL);
}
}
@@ -697,7 +697,7 @@
if (TLVP_PRES_LEN(&tp, NM_ATT_BTS_AIR_TIMER, 1)) {
uint8_t t3105 = *TLVP_VAL(&tp, NM_ATT_BTS_AIR_TIMER);
if (t3105 == 0) {
- LOGPFOH(DOML, LOGL_NOTICE, foh, "T3105 must have a
value != 0.\n");
+ LOGPFOH(DOML, LOGL_NOTICE, foh, "T3105 must have a
value != 0\n");
return oml_fom_ack_nack(msg, NM_NACK_PARAM_RANGE);
}
bts->t3105_ms = t3105 * 10;
@@ -824,7 +824,7 @@
if (arfcn >= 1024) { /* 0 .. 1023 (1024 channels total) */
oml_tx_failure_event_rep(&trx->bts->mo, NM_SEVER_MAJOR,
OSMO_EVT_WARN_SW_WARN,
"Given ARFCN %u is
unsupported", arfcn);
- LOGPFOH(DOML, LOGL_NOTICE, foh, "Given ARFCN %u is
unsupported.\n", arfcn);
+ LOGPFOH(DOML, LOGL_NOTICE, foh, "Given ARFCN %u is
unsupported\n", arfcn);
return oml_fom_ack_nack(msg, NM_NACK_FREQ_NOTAVAIL);
}
trx->arfcn = arfcn;
@@ -940,7 +940,7 @@
/* Check frequency hopping parameters (HSN, MAIO, ARFCN list) */
if (TLVP_PRESENT(&tp, NM_ATT_HSN) || TLVP_PRESENT(&tp, NM_ATT_MAIO)) {
if (!osmo_bts_has_feature(bts->features, BTS_FEAT_HOPPING)) {
- LOGPFOH(DOML, LOGL_ERROR, foh, "SET CHAN ATTR:
Frequency hopping not supported.\n");
+ LOGPFOH(DOML, LOGL_ERROR, foh, "SET CHAN ATTR:
Frequency hopping not supported\n");
return oml_fom_ack_nack(msg, NM_NACK_SPEC_IMPL_NOTSUPP);
}
@@ -974,7 +974,7 @@
/* 9.4.52 Starting Time */
if (TLVP_PRESENT(&tp, NM_ATT_START_TIME)) {
- LOGPFOH(DOML, LOGL_NOTICE, foh, "SET CHAN ATTR: Starting time
not supported.\n");
+ LOGPFOH(DOML, LOGL_NOTICE, foh, "SET CHAN ATTR: Starting time
not supported\n");
return oml_fom_ack_nack(msg, NM_NACK_SPEC_IMPL_NOTSUPP);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32219
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iaf061bb752f9808a6ab31049b9e87920a6b07f3d
Gerrit-Change-Number: 32219
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-MessageType: newchange
